A few cleanups and minor improvements to save_analysis #53927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @oli-obk (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
oli-obk
requested changes
Sep 3, 2018
| @@ -1608,8 +1605,7 @@ impl<'l, 'tcx: 'l, 'll, O: DumpOutput + 'll> Visitor<'l> for DumpVisitor<'l, 'tc | |||
| } | |||
| } | |||
| ast::ExprKind::Closure(_, _, _, ref decl, ref body, _fn_decl_span) => { | |||
| let mut id = String::from("$"); | |||
| id.push_str(&ex.id.to_string()); | |||
| let id = format!("${}", &ex.id); | |||
There was a problem hiding this comment.
the ampersand is unecessary
src/librustc_save_analysis/lib.rs
Outdated
| @@ -210,7 +210,7 @@ impl<'l, 'tcx: 'l> SaveContext<'l, 'tcx> { | |||
| decl_id: None, | |||
| docs: self.docs_for_attrs(&item.attrs), | |||
| sig: sig::item_signature(item, self), | |||
| attributes: lower_attributes(item.attrs.clone(), self), | |||
| attributes: lower_attributes(item.attrs.to_owned(), self), | |||
There was a problem hiding this comment.
seems weird to go from clone to to_owned. One wouldn't call to_owned on a &String, only on a &str I think?
There was a problem hiding this comment.
Both variants are currently present in the file and I thought that to_owned() would be preferable here, but I don't mind performing the change the other way around.
ljedrz
force-pushed
the
save_analysis_cleanups
branch
from
d14573d to
9883dd7
Compare
|
Thanks for the review, comments addressed. |
oli-obk
approved these changes
Sep 3, 2018
|
@bors r+ rollup Thx for the quick fix |
|
📌 Commit 9883dd7 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Sep 4, 2018
A few cleanups and minor improvements to save_analysis - calculate the capacity of some `Vec`s - change`to_owned()` to `clone()` for the purposes of `lower_attributes` - remove a superfluous `clone()` - prefer `to_owned()` to `to_string()` - a few other minor improvements
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vecsto_owned()toclone()for the purposes oflower_attributesclone()to_owned()toto_string()